Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet explorer does not seem to respond to the load/SVGLoad event for SVGImageElements #215

Open
atruskie opened this issue Jun 8, 2015 · 0 comments

Comments

@atruskie
Copy link
Member

atruskie commented Jun 8, 2015

We rely on the onload event to clean up the SVG in the distributionVisualisation.js after an image has loaded.

Other advantages include storing successful image downloads so that we do not have to render all the extra stuff needed by empty tiles.

The ultimate result, is that in IE only, when tile images sucessfully load:

  • we don't know or can't track this success
  • the ugly green placeholder tile remains
  • the text on the placeholder tile also remains

Only viable solution is to do HEAD requests to see if files exist before setting the xlink:href attribute on the image element.

See http://stackoverflow.com/questions/30713535/load-svgload-event-for-svgimageelement-in-internet-explorer for progress

atruskie added a commit that referenced this issue Jun 8, 2015
Now tracks image success and failure. It uses this info to generate cleaner
svg tiles (with out the palceholder rect and text). Cleaning is done when an image
is loaded, and after that, if the tile is loaded again, the extra svg is never generated.
These changes unfortunately do not work with internet explorer (see #215).

Also fixed firefox incompatibility (Fixes #198).
Also fixed the rendering of extra tiles (Fixes #201 and Fixes #196).
atruskie added a commit that referenced this issue Jul 20, 2015
Now tracks image success and failure. It uses this info to generate cleaner
svg tiles (with out the palceholder rect and text). Cleaning is done when an image
is loaded, and after that, if the tile is loaded again, the extra svg is never generated.
These changes unfortunately do not work with internet explorer (see #215).

Also fixed firefox incompatibility (Fixes #198).
Also fixed the rendering of extra tiles (Fixes #201 and Fixes #196).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant