Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add api backing for annotation verification #2221

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Add api backing for annotation verification #2221

wants to merge 21 commits into from

Conversation

hudson-newey
Copy link
Member

@hudson-newey hudson-newey commented Mar 3, 2025 •
edited
Loading

Add api backing for annotation verification

This PR adds support for api/database backed verifications

Changes

  • Backfills verification api endpoints, services, and models
  • Adds api backing for verification grid
  • Bump web components version
  • Makes AudioEvent models channel property writable
  • Updates TypeScript typings to allow combination InnerFilter arrays

Issues

Fixes: #2220

Final Checklist

  • Assign reviewers if you have permission
  • Assign labels if you have permission
  • Link issues related to PR
  • Ensure project linter is not producing any warnings (npm run lint)
  • Ensure build is passing on all browsers (npm run test:all)
  • Ensure CI build is passing
  • Ensure docker container is passing (docs)

@hudson-newey hudson-newey self-assigned this Mar 3, 2025
@hudson-newey hudson-newey added enhancement New feature or request triage:high High priority issue or pull request labels Mar 3, 2025
@hudson-newey hudson-newey changed the title Backfill verification services and tests Add api backing for annotation verification Mar 3, 2025
@hudson-newey hudson-newey marked this pull request as ready for review March 4, 2025 00:33
@hudson-newey hudson-newey requested a review from atruskie March 4, 2025 01:07
atruskie
atruskie approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@atruskie atruskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how the verification component is not that much more complex. Good job bundling the logic up into the service.

src/app/components/annotations/pages/verification/verification.component.ts
const mappedDecision =
confirmedMapping[subjectWrapper.verification.confirmed as string];

const tagId = subjectWrapper.tag.id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have we shipped tags having targets yet?

Copy link
Member Author

@hudson-newey hudson-newey Mar 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet

https://github.com/ecoacoustics/web-components/blob/1919d1d2f83bf5e69bf9167c05470fa3738b3882/src/models/tag.ts

Above is a commit locked link to tag model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atruskie atruskie atruskie approved these changes

Assignees

@hudson-newey hudson-newey

Labels
enhancement New feature or request triage:high High priority issue or pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add api backing for verification grid
2 participants
@hudson-newey @atruskie