Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: impore how we replace this in third-party code` #453

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix: impore how we replace this in third-party code` #453

merged 2 commits into from
Sep 15, 2023

Conversation

molszanski
Copy link
Contributor

@molszanski molszanski commented Aug 30, 2023 •
edited
Loading

What is it?

  • Bug
  • Docs / tests

Description

Better replaces this in third-party source code and avoids producing unrunnable code.

It was more described in #452

Use cases and why

eg: this replacing regex is breaking some scripts

    1. (Google Analytics via Segment)

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@vercel
Copy link

vercel bot commented Aug 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
partytown ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 6:44pm

mhevery
mhevery approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@molszanski
Copy link
Contributor Author

Can reproduce that err for Safari locally. Will check it

@mhevery
Copy link
Contributor

mhevery commented Sep 5, 2023

Can reproduce that err for Safari locally. Will check it

were you able to fix this? Would love to have this fix

@molszanski
Copy link
Contributor Author

were you able to fix this? Would love to have this fix

Will fix it! Had a hectic week :)

@mhevery
Copy link
Contributor

mhevery commented Sep 8, 2023

Will fix it! Had a hectic week :)

you rock!

@mhevery
Copy link
Contributor

mhevery commented Sep 15, 2023

Thank you. ❤️

@mhevery mhevery merged commit 0cc8e43 into QwikDev:main Sep 15, 2023
@molszanski
Copy link
Contributor Author

@mhevery will follow up with a cleanup in the next PR. Was having troubles with local tests on the main and wanted to check on CI

@molszanski molszanski deleted the bug/this branch October 3, 2023 12:43
@molszanski molszanski mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@molszanski @mhevery