Skip to content

Commit

Permalink
fix(ci): speed up windows test
Browse files Browse the repository at this point in the history
move firefox to ubuntu runner
  • Loading branch information
wmertens committed Jul 17, 2024
1 parent bb0cec1 commit 38fe43b
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
17 changes: 12 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,15 @@ jobs:
path: |
packages/docs/dist
packages/docs/server
key: ${{ hashfiles('pnpm-lock.yaml', 'packages/qwik/**/*', 'rust-toolchain', '**/Cargo.toml', '**/Cargo.lock', '**/*.rs', 'packages/qwik-city/**/*', 'packages/qwik-labs/**/*', 'packages/qwik-react/**/*', 'packages/qwik-docs/**/*') }}
key: ${{ hashfiles('pnpm-lock.yaml', 'packages/qwik/**/*', 'rust-toolchain', '**/Cargo.toml', '**/Cargo.lock', '**/*.rs', 'packages/qwik-city/**/*', 'packages/qwik-labs/**/*', 'packages/qwik-react/**/*', 'packages/docs/**/*') }}
- name: 'check cache: insights'
id: cache-insights
uses: actions/cache/restore@v4
with:
path: packages/qwik-insights/dist
lookup-only: true
path: |
packages/insights/dist
packages/insights/.netlify
key: ${{ hashfiles('pnpm-lock.yaml', 'packages/qwik/**/*', 'rust-toolchain', '**/Cargo.toml', '**/Cargo.lock', '**/*.rs', 'packages/qwik-city/**/*', 'packages/qwik-labs/**/*', 'packages/qwik-insights/**/*') }}

############ BUILD Qwik ############
Expand Down Expand Up @@ -448,7 +451,9 @@ jobs:
uses: actions/cache/save@v4
with:
key: ${{ needs.changes.outputs.hash-insights }}
path: packages/qwik-insights/dist
path: |
packages/insights/dist
packages/insights/.netlify
############ BUILD DOCS ############
build-docs:
Expand Down Expand Up @@ -585,10 +590,12 @@ jobs:
settings:
- host: ubuntu-latest
browser: chromium
- host: ubuntu-latest
browser: firefox
- host: macos-latest
browser: webkit
- host: windows-latest
browser: firefox
browser: chromium

runs-on: ${{ matrix.settings.host }}

Expand Down Expand Up @@ -625,7 +632,7 @@ jobs:
run: npx playwright install ${{ matrix.settings.browser }} --with-deps

- name: Playwright E2E Tests
run: pnpm run test.e2e.${{ matrix.settings.browser }} --timeout 60000 --retries 3 --workers 1
run: pnpm run test.e2e.${{ matrix.settings.browser }} --timeout 60000 --retries 7 --workers 1

- name: Validate Create Qwik Cli
run: pnpm cli.validate
Expand Down
2 changes: 2 additions & 0 deletions packages/docs/src/routes/(shop)/shop.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.shop .purple-gradient {
position: fixed;
pointer-events: none;
width: 1400px;
height: 800px;
top: 100px;
Expand All @@ -14,6 +15,7 @@

.shop .blue-gradient {
position: fixed;
pointer-events: none;
width: 1400px;
height: 1200px;
top: 600px;
Expand Down
1 change: 1 addition & 0 deletions starters/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const config: PlaywrightTestConfig = {
},
testIgnore: /.*example.spec.tsx?$/,
retries: 3,
expect: { timeout: 10000 },
webServer: {
command: "pnpm tsm ./starters/dev-server.ts 3301",
port: 3301,
Expand Down

0 comments on commit 38fe43b

Please sign in to comment.