Skip to content

Commit

Permalink
fix add event to element returned by signal
Browse files Browse the repository at this point in the history
  • Loading branch information
Varixo committed Aug 16, 2024
1 parent bdace09 commit 598747e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/qwik/src/core/v2/shared/component-execution.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { JSXNodeImpl, isJSXNode } from '../../render/jsx/jsx-runtime';
import type { JSXNode, JSXOutput } from '../../render/jsx/types/jsx-node';
import type { KnownEventNames } from '../../render/jsx/types/jsx-qwik-events';
import { SubscriptionType } from '../../state/common';
import { isSignal } from '../../state/signal';
import { invokeApply, newInvokeContext, untrack } from '../../use/use-core';
import { type EventQRL, type UseOnMap } from '../../use/use-on';
import { EMPTY_OBJ } from '../../util/flyweight';
Expand All @@ -22,6 +21,7 @@ import { isPromise, maybeThen, safeCall } from '../../util/promises';
import type { ValueOrPromise } from '../../util/types';
import type { Container2, HostElement, fixMeAny } from './types';
import { logWarn } from '../../util/log';
import { isSignal2 } from '../signal/v2-signal';

/**
* Use `executeComponent2` to execute a component.
Expand Down Expand Up @@ -196,7 +196,7 @@ function findFirstStringJSX(jsx: JSXOutput): ValueOrPromise<JSXNode<string> | nu
queue.push(...jsx);
} else if (isPromise(jsx)) {
return maybeThen<JSXOutput, JSXNode<string> | null>(jsx, (jsx) => findFirstStringJSX(jsx));
} else if (isSignal(jsx)) {
} else if (isSignal2(jsx)) {
return findFirstStringJSX(untrack(() => jsx.value as JSXOutput));
}
}
Expand Down

0 comments on commit 598747e

Please sign in to comment.