Skip to content

Commit

Permalink
perf(bundle): remove entries
Browse files Browse the repository at this point in the history 
The bundler should handle entries. Prefetching can still indicate the full graph to fetch and http2 makes that fast.
  • Loading branch information
@wmertens
wmertens committed May 24, 2024
1 parent 8c7a250 commit cf8fa7f
Show file tree
Hide file tree
Showing 14 changed files with 109 additions and 238 deletions.
1 change: 1 addition & 0 deletions packages/docs/vite.config.mts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ export default defineConfig(async () => {
defaultHandler(level, log);
},
output: {
experimentalMinChunkSize: 5000,
assetFileNames: 'assets/[hash].[ext]',
},
},
Expand Down
32 changes: 12 additions & 20 deletions packages/qwik/src/optimizer/core/src/snapshots/qwik_core__test__example_11.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,19 @@ export const App = component$(() => {
);
});

============================= project/header_component_header_onclick_kjd9tcnknxy.tsx ==
============================= project/header_component_header_onclick_kjd9tcnknxy.tsx (ENTRY POINT)==

import dep3 from "dep3/something";
export const Header_component_Header_onClick_KjD9TCNkNxY = (ev)=>dep3(ev);
export { _hW } from "@builder.io/qwik";


Some("{\"version\":3,\"sources\":[\"/user/qwik/src/project/test.tsx\"],\"names\":[],\"mappings\":\";2DAQ2B,CAAC,KAAO,KAAK\"}")
/*
{
"origin": "project/test.tsx",
"name": "Header_component_Header_onClick_KjD9TCNkNxY",
"entry": "entry_hooks",
"entry": null,
"displayName": "Header_component_Header_onClick",
"hash": "KjD9TCNkNxY",
"canonicalFilename": "header_component_header_onclick_kjd9tcnknxy",
Expand All @@ -52,27 +53,27 @@ Some("{\"version\":3,\"sources\":[\"/user/qwik/src/project/test.tsx\"],\"names\"
]
}
*/
============================= project/header_component_uvbjufyfvdo.tsx ==
============================= project/header_component_uvbjufyfvdo.tsx (ENTRY POINT)==

import { Header } from "./test";
import { bar as bbar } from "../state";
import * as dep2 from "dep2";
import { qrl } from "@builder.io/qwik";
export const Header_component_UVBJuFYfvDo = ()=>{
return <Header onClick={/*#__PURE__*/ qrl(()=>import("./entry_hooks"), "Header_component_Header_onClick_KjD9TCNkNxY")}>
return <Header onClick={/*#__PURE__*/ qrl(()=>import("./header_component_header_onclick_kjd9tcnknxy"), "Header_component_Header_onClick_KjD9TCNkNxY")}>

{dep2.stuff()}{bbar()}

</Header>;
};


Some("{\"version\":3,\"sources\":[\"/user/qwik/src/project/test.tsx\"],\"names\":[],\"mappings\":\";;;;4CAMiC,IAAM;IACnC,QACK,OAAO,wGAA8B;;YAClC,CAAC,KAAK,KAAK,IAAI,OAAO;;QAC1B,EAAE;AAEV\"}")
Some("{\"version\":3,\"sources\":[\"/user/qwik/src/project/test.tsx\"],\"names\":[],\"mappings\":\";;;;4CAMiC,IAAM;IACnC,QACK,OAAO,wIAA8B;;YAClC,CAAC,KAAK,KAAK,IAAI,OAAO;;QAC1B,EAAE;AAEV\"}")
/*
{
"origin": "project/test.tsx",
"name": "Header_component_UVBJuFYfvDo",
"entry": "entry_hooks",
"entry": null,
"displayName": "Header_component",
"hash": "UVBJuFYfvDo",
"canonicalFilename": "header_component_uvbjufyfvdo",
Expand All @@ -88,7 +89,7 @@ Some("{\"version\":3,\"sources\":[\"/user/qwik/src/project/test.tsx\"],\"names\"
]
}
*/
============================= project/app_component_wgkrhwxaqjs.tsx ==
============================= project/app_component_wgkrhwxaqjs.tsx (ENTRY POINT)==

import { Header } from "./test";
import { foo } from "../state";
Expand All @@ -102,7 +103,7 @@ Some("{\"version\":3,\"sources\":[\"/user/qwik/src/project/test.tsx\"],\"names\"
{
"origin": "project/test.tsx",
"name": "App_component_wGkRHWXaqjs",
"entry": "entry_hooks",
"entry": null,
"displayName": "App_component",
"hash": "wGkRHWXaqjs",
"canonicalFilename": "app_component_wgkrhwxaqjs",
Expand All @@ -122,20 +123,11 @@ Some("{\"version\":3,\"sources\":[\"/user/qwik/src/project/test.tsx\"],\"names\"

import { componentQrl } from "@builder.io/qwik";
import { qrl } from "@builder.io/qwik";
export const Header = /*#__PURE__*/ componentQrl(/*#__PURE__*/ qrl(()=>import("./entry_hooks"), "Header_component_UVBJuFYfvDo"));
export const App = /*#__PURE__*/ componentQrl(/*#__PURE__*/ qrl(()=>import("./entry_hooks"), "App_component_wGkRHWXaqjs"));


Some("{\"version\":3,\"sources\":[\"/user/qwik/src/project/test.tsx\"],\"names\":[],\"mappings\":\";;AAMA,OAAO,MAAM,uBAAS,6FAMnB;AAEH,OAAO,MAAM,oBAAM,0FAIhB\"}")
============================= entry_hooks.js (ENTRY POINT)==

export { Header_component_Header_onClick_KjD9TCNkNxY } from "./header_component_header_onclick_kjd9tcnknxy";
export { Header_component_UVBJuFYfvDo } from "./header_component_uvbjufyfvdo";
export { App_component_wGkRHWXaqjs } from "./app_component_wgkrhwxaqjs";
export { _hW } from "@builder.io/qwik";
export const Header = /*#__PURE__*/ componentQrl(/*#__PURE__*/ qrl(()=>import("./header_component_uvbjufyfvdo"), "Header_component_UVBJuFYfvDo"));
export const App = /*#__PURE__*/ componentQrl(/*#__PURE__*/ qrl(()=>import("./app_component_wgkrhwxaqjs"), "App_component_wGkRHWXaqjs"));


None
Some("{\"version\":3,\"sources\":[\"/user/qwik/src/project/test.tsx\"],\"names\":[],\"mappings\":\";;AAMA,OAAO,MAAM,uBAAS,8GAMnB;AAEH,OAAO,MAAM,oBAAM,wGAIhB\"}")
== DIAGNOSTICS ==

[]
14 changes: 4 additions & 10 deletions packages/qwik/src/optimizer/core/src/snapshots/qwik_core__test__example_default_export.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ export default component$(() => {

import { componentQrl } from "@builder.io/qwik";
import { qrl } from "@builder.io/qwik";
export default /*#__PURE__*/ componentQrl(/*#__PURE__*/ qrl(()=>import("./entry______slug__.js"), "_____slug___component_vgk6N3QaQd4"));
export default /*#__PURE__*/ componentQrl(/*#__PURE__*/ qrl(()=>import("./_____slug___component_vgk6n3qaqd4.js"), "_____slug___component_vgk6N3QaQd4"));


Some("{\"version\":3,\"sources\":[\"/user/qwik/src/src/routes/_repl/[id]/[[...slug]].tsx\"],\"names\":[],\"mappings\":\";;AAIA,6BAAe,2GAKZ\"}")
Some("{\"version\":3,\"sources\":[\"/user/qwik/src/src/routes/_repl/[id]/[[...slug]].tsx\"],\"names\":[],\"mappings\":\";;AAIA,6BAAe,2HAKZ\"}")
============================= src/routes/_repl/[id]/_____slug___component_div_onclick_oesymv0so3o.js (ENTRY POINT)==

import { sibling } from "./sibling";
Expand Down Expand Up @@ -52,7 +52,7 @@ Some("{\"version\":3,\"sources\":[\"/user/qwik/src/src/routes/_repl/[id]/[[...sl
]
}
*/
============================= src/routes/_repl/[id]/_____slug___component_vgk6n3qaqd4.js ==
============================= src/routes/_repl/[id]/_____slug___component_vgk6n3qaqd4.js (ENTRY POINT)==

import { _jsxQ } from "@builder.io/qwik";
import { qrl } from "@builder.io/qwik";
Expand All @@ -68,7 +68,7 @@ Some("{\"version\":3,\"sources\":[\"/user/qwik/src/src/routes/_repl/[id]/[[...sl
{
"origin": "src/routes/_repl/[id]/[[...slug]].tsx",
"name": "_____slug___component_vgk6N3QaQd4",
"entry": "src/routes/_repl/[id]/entry______slug__",
"entry": null,
"displayName": "_____slug___component",
"hash": "vgk6N3QaQd4",
"canonicalFilename": "_____slug___component_vgk6n3qaqd4",
Expand All @@ -84,12 +84,6 @@ Some("{\"version\":3,\"sources\":[\"/user/qwik/src/src/routes/_repl/[id]/[[...sl
]
}
*/
============================= src/routes/_repl/[id]/entry______slug__.js (ENTRY POINT)==

export { _____slug___component_vgk6N3QaQd4 } from "./_____slug___component_vgk6n3qaqd4.js";


None
== DIAGNOSTICS ==

[]
30 changes: 11 additions & 19 deletions .../src/optimizer/core/src/snapshots/qwik_core__test__example_explicit_ext_no_transpile.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ export const App = component$((props) => {

import { componentQrl } from "@builder.io/qwik";
import { qrl } from "@builder.io/qwik";
export const App = /*#__PURE__*/ componentQrl(/*#__PURE__*/ qrl(()=>import("./entry_hooks.tsx"), "App_component_ckEPmXZlub0"));
export const App = /*#__PURE__*/ componentQrl(/*#__PURE__*/ qrl(()=>import("./app_component_ckepmxzlub0.tsx"), "App_component_ckEPmXZlub0"));


Some("{\"version\":3,\"sources\":[\"/user/qwik/src/test.tsx\"],\"names\":[],\"mappings\":\";;AAGA,OAAO,MAAM,oBAAM,8FAKhB\"}")
============================= app_component_usestyles_t35nsa5uv7u.tsx ==
Some("{\"version\":3,\"sources\":[\"/user/qwik/src/test.tsx\"],\"names\":[],\"mappings\":\";;AAGA,OAAO,MAAM,oBAAM,4GAKhB\"}")
============================= app_component_usestyles_t35nsa5uv7u.tsx (ENTRY POINT)==

export const App_component_useStyles_t35nSa5UV7U = 'hola';

Expand All @@ -33,7 +33,7 @@ Some("{\"version\":3,\"sources\":[\"/user/qwik/src/test.tsx\"],\"names\":[],\"ma
{
"origin": "test.tsx",
"name": "App_component_useStyles_t35nSa5UV7U",
"entry": "entry_hooks",
"entry": null,
"displayName": "App_component_useStyles",
"hash": "t35nSa5UV7U",
"canonicalFilename": "app_component_usestyles_t35nsa5uv7u",
Expand All @@ -49,13 +49,13 @@ Some("{\"version\":3,\"sources\":[\"/user/qwik/src/test.tsx\"],\"names\":[],\"ma
]
}
*/
============================= app_component_ckepmxzlub0.tsx ==
============================= app_component_ckepmxzlub0.tsx (ENTRY POINT)==

import { qrl } from "@builder.io/qwik";
import { useStylesQrl } from "@builder.io/qwik";
export const App_component_ckEPmXZlub0 = (props)=>{
useStylesQrl(/*#__PURE__*/ qrl(()=>import("./entry_hooks.tsx"), "App_component_useStyles_t35nSa5UV7U"));
return /*#__PURE__*/ qrl(()=>import("./entry_hooks.tsx"), "App_component_1_w0t0o3QMovU");
useStylesQrl(/*#__PURE__*/ qrl(()=>import("./app_component_usestyles_t35nsa5uv7u.tsx"), "App_component_useStyles_t35nSa5UV7U"));
return /*#__PURE__*/ qrl(()=>import("./app_component_1_w0t0o3qmovu.tsx"), "App_component_1_w0t0o3QMovU");
};


Expand All @@ -64,7 +64,7 @@ Some("{\"version\":3,\"sources\":[\"/user/qwik/src/test.tsx\"],\"names\":[],\"ma
{
"origin": "test.tsx",
"name": "App_component_ckEPmXZlub0",
"entry": "entry_hooks",
"entry": null,
"displayName": "App_component",
"hash": "ckEPmXZlub0",
"canonicalFilename": "app_component_ckepmxzlub0",
Expand All @@ -80,17 +80,18 @@ Some("{\"version\":3,\"sources\":[\"/user/qwik/src/test.tsx\"],\"names\":[],\"ma
]
}
*/
============================= app_component_1_w0t0o3qmovu.tsx ==
============================= app_component_1_w0t0o3qmovu.tsx (ENTRY POINT)==

export const App_component_1_w0t0o3QMovU = ()=><div></div>;
export { _hW } from "@builder.io/qwik";


Some("{\"version\":3,\"sources\":[\"/user/qwik/src/test.tsx\"],\"names\":[],\"mappings\":\"2CAKa,KACJ,MAAM\"}")
/*
{
"origin": "test.tsx",
"name": "App_component_1_w0t0o3QMovU",
"entry": "entry_hooks",
"entry": null,
"displayName": "App_component_1",
"hash": "w0t0o3QMovU",
"canonicalFilename": "app_component_1_w0t0o3qmovu",
Expand All @@ -106,15 +107,6 @@ Some("{\"version\":3,\"sources\":[\"/user/qwik/src/test.tsx\"],\"names\":[],\"ma
]
}
*/
============================= entry_hooks.js (ENTRY POINT)==

export { App_component_useStyles_t35nSa5UV7U } from "./app_component_usestyles_t35nsa5uv7u.tsx";
export { App_component_ckEPmXZlub0 } from "./app_component_ckepmxzlub0.tsx";
export { App_component_1_w0t0o3QMovU } from "./app_component_1_w0t0o3qmovu.tsx";
export { _hW } from "@builder.io/qwik";


None
== DIAGNOSTICS ==

[]
14 changes: 4 additions & 10 deletions ...es/qwik/src/optimizer/core/src/snapshots/qwik_core__test__example_fix_dynamic_import.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const Header = component$(() => {
);
});

============================= project/folder/header_component_rggm7ks9qwi.tsx ==
============================= project/folder/header_component_rggm7ks9qwi.tsx (ENTRY POINT)==

import thing from "../state";
export const Header_component_RGgm7Ks9QWI = ()=>{
Expand All @@ -41,7 +41,7 @@ Some("{\"version\":3,\"sources\":[\"/user/qwik/src/project/folder/test.tsx\"],\"
{
"origin": "project/folder/test.tsx",
"name": "Header_component_RGgm7Ks9QWI",
"entry": "entry_hooks",
"entry": null,
"displayName": "Header_component",
"hash": "RGgm7Ks9QWI",
"canonicalFilename": "header_component_rggm7ks9qwi",
Expand All @@ -64,16 +64,10 @@ import { qrl } from "@builder.io/qwik";
export function foo() {
return import("../state");
}
export const Header = /*#__PURE__*/ componentQrl(/*#__PURE__*/ qrl(()=>import("./entry_hooks"), "Header_component_RGgm7Ks9QWI"));
export const Header = /*#__PURE__*/ componentQrl(/*#__PURE__*/ qrl(()=>import("./header_component_rggm7ks9qwi"), "Header_component_RGgm7Ks9QWI"));


Some("{\"version\":3,\"sources\":[\"/user/qwik/src/project/folder/test.tsx\"],\"names\":[],\"mappings\":\";;AAIA,OAAO,SAAS,MAAM;IAClB,OAAO,MAAM,CAAC;AAClB,CAAC;AAED,OAAO,MAAM,uBAAS,6FAOnB\"}")
============================= entry_hooks.js (ENTRY POINT)==

export { Header_component_RGgm7Ks9QWI } from "./header_component_rggm7ks9qwi";


None
Some("{\"version\":3,\"sources\":[\"/user/qwik/src/project/folder/test.tsx\"],\"names\":[],\"mappings\":\";;AAIA,OAAO,SAAS,MAAM;IAClB,OAAO,MAAM,CAAC;AAClB,CAAC;AAED,OAAO,MAAM,uBAAS,8GAOnB\"}")
== DIAGNOSTICS ==

[]
Loading

0 comments on commit cf8fa7f

Please sign in to comment.