-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(optimizer): let the bundler handle entries #6670
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
201e461
to
7fdea60
Compare
commit:
|
I'm hoping that we can get traction on rollup/rollup#5574 |
7fdea60
to
457d46e
Compare
✅ Deploy Preview for qwik-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Running preview on Qwik UI I get:
Node.js v20.15.1 I removed a few Also I can't print out the symbol file name (#6673) which could help in debugging this further. |
Ok thanks for testing. We'll see what rollup does. |
457d46e
to
786141c
Compare
🦋 Changeset detectedLatest commit: e4777bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
786141c
to
5b43f26
Compare
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
5b43f26
to
00b1473
Compare
The existing side effects should be retained so that e.g. serviceworker entries don't get cleared out (they are only side effects)
- removes entry creating from optimizer - adds manualChunks option that tells Rollup which chunks to put together - removes building at buildStart so other plugins can transform before the segment splitting
the parent information from the dev qrl data is sufficient
00b1473
to
e4777bf
Compare
This makes the Qwik rollup plugin behave like a normal plugin, and speeds up dev startup.