fix(v2): qwik react #6722
Merged
fix(v2): qwik react #6722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Varixo
commented
Jul 25, 2024
Comment on lines
-189
to
-207
| // This is only used in v1, in v2 we use componentQrl directly | ||
| function QwikComponent(props: PublicProps<PROPS>, key: string | null, flags: number): JSXNode { | ||
| assertQrl(componentQrl); | ||
| assertNumber(flags, 'The Qwik Component was not invoked correctly'); | ||
| const hash = qTest ? 'sX' : componentQrl.$hash$.slice(0, 4); | ||
| const finalKey = hash + ':' + (key ? key : ''); | ||
| return _jsxSorted( | ||
| Virtual, | ||
| { | ||
| props, | ||
| [OnRenderProp]: componentQrl, | ||
| [QSlot]: props[QSlot], | ||
| }, | ||
| null, | ||
| props.children, | ||
| flags, | ||
| finalKey | ||
| ) as any; | ||
| } |
There was a problem hiding this comment.
for some reason for the qwik-react here is returning error. This is not needed in v2, so I removed it
| @@ -232,6 +232,7 @@ export const vnode_diff = ( | |||
| } | |||
| } else if (jsxValue === SkipRender) { | |||
| // do nothing, we are skipping this node | |||
| journal = []; | |||
There was a problem hiding this comment.
is there any better way to ignore journal? @mhevery
wmertens
approved these changes
Jul 25, 2024
mhevery
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix most problems with qwik react in v2