Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signals): computedSignal QRL handling #6907

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix(signals): computedSignal QRL handling #6907

merged 2 commits into from
Sep 24, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Sep 23, 2024

makes computed signals work and enforces that the calculation doesn't return a Promise (also via types)

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: eae2ed8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 24, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6907
npm i https://pkg.pr.new/@builder.io/qwik-city@6907
npm i https://pkg.pr.new/eslint-plugin-qwik@6907
npm i https://pkg.pr.new/create-qwik@6907

commit: eae2ed8

Copy link
Contributor

github-actions bot commented Sep 24, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview eae2ed8

@wmertens wmertens merged commit 00c599d into build/v2 Sep 24, 2024
16 checks passed
@wmertens wmertens deleted the v2-opt branch September 24, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant