fix(qwikVite): stale QRL segments in dev mode #6945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6d70625 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wmertens
force-pushed
the
refactor-plugin
branch
from
51c4a69 to
3336aa4
Compare
wmertens
force-pushed
the
refactor-plugin
branch
5 times, most recently
from
496e889 to
d9aa89e
Compare
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
shairez
reviewed
Oct 15, 2024
wmertens
force-pushed
the
refactor-plugin
branch
from
d9aa89e to
4f98f98
Compare
this prevents duplicate vite versions
this is especially problematic in dev
- more robust dev server URL handling in resolveId - remove ?_qrl_parent query and rely only on path - remove foundQrls export, instead only keep track of generated segments' parents in parentIds - enforce externals while building libraries, this is suddenly needed because of these changes - better hot update invalidation - more robust getSymbolHash
Nix now supports playwright 1.47.0, and the old version broke CI
wmertens
force-pushed
the
refactor-plugin
branch
from
4f98f98 to
6d70625
Compare
shairez
approved these changes
Oct 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the plugin code and tries harder to make updated QRL segments get into the browser.
Fix #6935