Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(signals): schedule signal computation and run effects through the scheduler #7088

Merged
merged 16 commits into from
Dec 19, 2024
Merged

fix(signals): schedule signal computation and run effects through the scheduler #7088

merged 16 commits into from
Dec 19, 2024

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Nov 23, 2024 •
edited
Loading

  • move signal invalidation to the scheduler
  • improve ssrnode attributes serialization
  • serialize virtual props for DOM elements
  • prevent signals memory leaks

@Varixo Varixo self-assigned this Nov 23, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: a95c2e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo changed the title fix(signals): schedule signal computation and running effects through the scheduler fix(signals): schedule signal computation and run effects through the scheduler Nov 23, 2024
@Varixo Varixo force-pushed the v2-schedule-recomputation branch from 7d5132f to 7cb05cc Compare November 24, 2024 14:24
@Varixo Varixo force-pushed the v2-schedule-recomputation branch from b757260 to a5b2b8e Compare November 25, 2024 18:07
@Varixo Varixo force-pushed the v2-schedule-recomputation branch from cf0d753 to 8693165 Compare November 29, 2024 15:01
@Varixo Varixo marked this pull request as ready for review December 10, 2024 13:27
@Varixo Varixo requested a review from a team as a code owner December 10, 2024 13:27
@Varixo Varixo requested a review from mhevery December 10, 2024 13:47
@Varixo Varixo requested a review from a team as a code owner December 12, 2024 16:39
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 13, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7088

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7088

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7088

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7088

commit: a95c2e6

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview a95c2e6

This was linked to issues Dec 19, 2024
[🐞] Qwik doesnt check if-statements before running child useComputed$ or useTask$ #4332
Closed
[🐞] v2: captured scope doesn't update in csr #7032
Closed
@Varixo Varixo merged commit ccbb690 into build/v2 Dec 19, 2024
19 checks passed
@Varixo Varixo deleted the v2-schedule-recomputation branch December 19, 2024 14:33
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Merged
@Varixo Varixo mentioned this pull request Dec 20, 2024
Closed
@Varixo Varixo removed a link to an issue Dec 29, 2024
[🐞] v2: captured scope doesn't update in csr #7032
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens left review comments

@mhevery mhevery mhevery approved these changes

@shairez shairez shairez approved these changes

Assignees

@Varixo Varixo

Labels
VERSION: upcoming major
Projects
Qwik Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐞] Qwik doesnt check if-statements before running child useComputed$ or useTask$
4 participants
@Varixo @wmertens @mhevery @shairez