Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readme to dashboard pipeline #118

Merged
merged 6 commits into from
Aug 13, 2021
Merged

Add readme to dashboard pipeline #118

merged 6 commits into from
Aug 13, 2021

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Aug 9, 2021

  • Adds readme to radar-jdbc-connector and radar-grafana

Resolves #98

@github-actions
Copy link

github-actions bot commented Aug 9, 2021 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files

@nivemaham nivemaham changed the base branch from chart-docs to dev August 10, 2021 09:51
@keyvaann
Copy link
Collaborator

@mpgxvii Please also add your name to maintainers list.

@nivemaham
Copy link
Contributor

nivemaham commented Aug 11, 2021 •
edited
Loading

I'm wondering, should we also include the timescaledb in this PR? @mpgxvii Was it you who worked on it or was it @K1Hyve ?

nivemaham
nivemaham approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@nivemaham nivemaham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nivemaham nivemaham merged commit 85e8ed1 into dev Aug 13, 2021
@keyvaann keyvaann deleted the dashboard-docs branch August 16, 2021 09:38
blootsvoets pushed a commit that referenced this pull request Dec 21, 2022
@nivemaham
Merge pull request #118 from RADAR-base/dashboard-docs
dec9329 
Add readme to dashboard pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivemaham nivemaham nivemaham approved these changes

@keyvaann keyvaann Awaiting requested review from keyvaann

@blootsvoets blootsvoets Awaiting requested review from blootsvoets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpgxvii @keyvaann @nivemaham