Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve chart template #126

Merged
merged 9 commits into from
Aug 13, 2021
Merged

Improve chart template #126

merged 9 commits into from
Aug 13, 2021

Conversation

keyvaann
Copy link
Collaborator

Refer to #117 for more info.

@keyvaann keyvaann requested a review from nivemaham August 13, 2021 11:49
@github-actions
Copy link

github-actions bot commented Aug 13, 2021

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files

* dev:
  Update radar-jdbc-connector README
  Update radar-grafana README
  Add initial readme to radar-grafana
  Add comments/docs to jdbc-connector values.yaml
  Add README for jdbc connector
Copy link
Contributor

@nivemaham nivemaham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Keyvan <[email protected]>
@keyvaann keyvaann merged commit 5282eb4 into dev Aug 13, 2021
@keyvaann keyvaann deleted the improve-chart-template branch August 13, 2021 13:05
blootsvoets pushed a commit that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants