Remove outdated SMTP chart #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
3 tasks
|
What should we do in the meantime? |
|
Yes, in all our installations, we currently configure SMTP directly in the component that uses SMTP. So this chart is not being used. |
|
I see. @blootsvoets Are we going to make the SMTP a prerequisite or would you look into configuring the post-fix relay? |
|
An external SMTP server is always a prerequisite. We can keep configuring SMTP as we currently do, per component. |
blootsvoets
added a commit
that referenced
this pull request
Dec 21, 2022
Remove outdated SMTP chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SMTP chart is not being used. Also the
namshi/smtpdocker image seems unmaintained. Possible future action: use an existing up-to-date postfix relay client chart instead (like https://artifacthub.io/packages/helm/docker-postfix/mail). This PR removes the chart.