Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor config update in realtime dashboard #233

Merged
merged 2 commits into from
Mar 30, 2023
Merged

minor config update in realtime dashboard #233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cc0653
Merge pull request #227 from RADAR-base/release-1.1.0
keyvaann Mar 28, 2023
f413232
minor config update in realtime dashboard
Hsankesara Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helmfile.d/40-realtime-dashboard.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ releases:
set:
- name: kafka_num_brokers
value: {{ .Values.kafka_num_brokers }}
- name: jdbc.username
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've seen this change before, was it in this component or JDBC connector?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. I think it is jdbc.user in jdbc-connector but jdbc.username in jdbc-connector-agg

- name: jdbc.user
value: {{ .Values.timescaledb_username }}
- name: jdbc.password
value: {{ .Values.timescaledb_password }}
Expand Down