Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/generate-random-minio-credentials #316

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

pvannierop
Copy link
Contributor

Problem

At present, the admin username and passwords are not updated by the generate-passwords script and remain change_me/change_me.

Solution

This PR will enable the generate-passwords script to create Minio passwords.

@pvannierop pvannierop requested a review from keyvaann August 26, 2024 11:28
@pvannierop pvannierop self-assigned this Aug 26, 2024
@keyvaann keyvaann changed the base branch from main to dev August 27, 2024 08:40
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvannierop pvannierop force-pushed the bugfix/generate-random-minio-credentials branch from da1eaac to 0cbb195 Compare August 27, 2024 10:01
@pvannierop pvannierop force-pushed the bugfix/generate-random-minio-credentials branch from 0cbb195 to 55d7acc Compare August 28, 2024 09:56
@pvannierop pvannierop merged commit f3b8997 into dev Aug 28, 2024
3 checks passed
@pvannierop pvannierop deleted the bugfix/generate-random-minio-credentials branch October 15, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants