Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump bitcoind dependency and version #18

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

apoelstra
Copy link
Contributor

Needed to update rust-elements.

@apoelstra
Copy link
Contributor Author

I did not look at whether the latest version of bitcoind supports any new bitcoind versions or features; I just bumped the dep and checked whether it worked.

In fact we could do a ranged dependency, changing from 0.34 to ">=0.34.0, <=0.36.0" ... and probably even lower the range below 0.34.0. But I don't think there's really any value in doing that. It would let people use the same elementsd version across multiple versions of bitcoin but what does that gain us?

@RCasatta
Copy link
Owner

Sorry for the delay, I was in PTO...

ACK 328e1f6

In fact we could do a ranged dependency, changing from 0.34 to ">=0.34.0, <=0.36.0" ... and probably even lower the range below 0.34.0. But I don't think there's really any value in doing that. It would let people use the same elementsd version across multiple versions of bitcoin but what does that gain us?

Having range dep could help in avoiding multiple versions in some cases? but I think it can introduce some maintenance cost (should multiple version being tested than?) So, yeah, I don't think it's worth it.

@RCasatta RCasatta merged commit 328e1f6 into RCasatta:master Jul 29, 2024
12 checks passed
@RCasatta
Copy link
Owner

Sorry for the delay, I was in PTO...

BTW I now added @LeoComandini as mantainer, I forgot this one was without a second mantainer

@RCasatta
Copy link
Owner

And also released on crate https://crates.io/crates/elementsd

@apoelstra apoelstra deleted the 2024-07--update-bitcoind branch July 30, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants