Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot clone it on windows #901

Closed
SeekPoint opened this issue Mar 5, 2019 · 6 comments · Fixed by #971
Closed

cannot clone it on windows #901

SeekPoint opened this issue Mar 5, 2019 · 6 comments · Fixed by #971
Labels
bug Something isn't working meta Relates primarily to the project and not users of the project.
Milestone

Comments

@SeekPoint
Copy link

C:\ub16_prj>git clone https://github.com/RDFLib/rdflib
Cloning into 'rdflib'...
remote: Enumerating objects: 40, done.
remote: Counting objects: 100% (40/40), done.
remote: Compressing objects: 100% (25/25), done.
remote: Total 20819 (delta 16), reused 30 (delta 15), pack-reused 20779
Receiving objects: 100% (20819/20819), 12.29 MiB | 751.00 KiB/s, done.
Resolving deltas: 100% (13280/13280), done.
error: unable to create file test_reports/rdflib_nquads-2013-12-22T19:22:34.ttl: Invalid argument
error: unable to create file test_reports/rdflib_nt-2013-12-22T19:12:25.ttl: Invalid argument
error: unable to create file test_reports/rdflib_sparql-2013-12-22T19:36:48.ttl: Invalid argument
error: unable to create file test_reports/rdflib_trig-2013-12-22T19:31:52.ttl: Invalid argument
error: unable to create file test_reports/rdflib_trig-2013-12-30T15:56:57.ttl: Invalid argument
error: unable to create file test_reports/rdflib_turtle-2013-12-22T19:13:51.ttl: Invalid argument
Checking out files: 100% (4439/4439), done.
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

@kinow
Copy link
Contributor

kinow commented Mar 5, 2019

Probably due to colon (:) in the file name, which is an illegal character in Windows: https://stackoverflow.com/questions/5991805/how-do-i-clone-files-with-colons-in-the-filename

@SeekPoint
Copy link
Author

so, maybe we should change it compatible with windows

@joernhees
Copy link
Member

hmm, not sure if simply changing the files is enough, as they're probably generated and might be referenced by name somewhere... will reopen this as even though it's annoying, we actually should support windows...

@joernhees joernhees reopened this Mar 5, 2019
@joernhees joernhees added bug Something isn't working meta Relates primarily to the project and not users of the project. labels Mar 5, 2019
@joernhees joernhees added this to the rdflib 5.0.0 milestone Mar 5, 2019
@white-gecko
Copy link
Member

white-gecko commented Mar 15, 2020

They are generated here:

$ ack test_reports
test/test_dawg.py
616:        earl_report = 'test_reports/rdflib_sparql-%s.ttl' % now
619:        report.serialize('test_reports/rdflib_sparql-latest.ttl', format='n3')

test/testutils.py
99:        earl_report = 'test_reports/%s-%s.ttl' % (earl_report_name, now)
102:        report.serialize('test_reports/%s-latest.ttl'%earl_report_name, format='n3')

@white-gecko
Copy link
Member

white-gecko commented Mar 15, 2020

They might be relevant for the W3C implementation reports https://dvcs.w3.org/hg/rdf/raw-file/default/rdf-turtle/reports/index.html.
@gromgull you have submitted them back than. Is it important to stick to the naming scheme of using the ISO date in the filename?

How do I produce the EARL reports?
Uncommenting --with-EAR in run_tests.py resulted in:

Running nose with: --attr= test rdflib --where=./ --with-doctest --doctest-extension=.doctest --doctest-tests --with-EARL
Usage: run_tests.py [options]

run_tests.py: error: no such option: --with-EARL

@gromgull
Copy link
Member

I guess being able to clone on windows is in any case more important than w3c reports :D

Only test_dawg will write reports (they are only relevant for SPARQL)

https://github.com/RDFLib/rdflib/blob/master/test/test_dawg.py#L616-L620

nicholascar added a commit that referenced this issue Mar 15, 2020
…eports

Remove colons from test result files. Fix #901.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working meta Relates primarily to the project and not users of the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants