-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tox config #1313
Fix tox config #1313
Conversation
2 similar comments
The current tox config does not work as the dependencies are out of sync and doctest has troubles with xunit. This fixes it so that tox works again and makes it easier for other people to contribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me but please accept my PR to your branch first which updates the tox supported Python versions which should now be 3.6, - 3.9 only. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, in addition to my Python version update, please remove space between -r
and requirements files, as per StackOverflow
update supported Python versions
As @nicholascar pointed out this causes problems in some cases.
Changed it as requested, thanks for the heads up :) |
@white-gecko @ashleysommer over to you. Looks good to me |
The current tox config does not work as the dependencies are out of sync
and doctest has troubles with xunit.
This fixes it so that tox works again and makes it easier for other
people to contribute.
Fixes #1312
Proposed Changes
requirements.txt
andrequirements.dev.txt
instead of duplicating requirements.