Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tox config #1313

Merged
merged 4 commits into from
Jun 19, 2021
Merged

Fix tox config #1313

merged 4 commits into from
Jun 19, 2021

Conversation

aucampia
Copy link
Member

The current tox config does not work as the dependencies are out of sync
and doctest has troubles with xunit.

This fixes it so that tox works again and makes it easier for other
people to contribute.

Fixes #1312

Proposed Changes

  • Don't run tests with xunit
  • Use requirements.txt and requirements.dev.txt instead of duplicating requirements.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.523% when pulling 9197e7b on iafork:fix_tox into 8d592a2 on RDFLib:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.523% when pulling 9197e7b on iafork:fix_tox into 8d592a2 on RDFLib:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.523% when pulling 9197e7b on iafork:fix_tox into 8d592a2 on RDFLib:master.

@coveralls
Copy link

coveralls commented May 14, 2021

Coverage Status

Coverage decreased (-0.006%) to 75.517% when pulling 3d42597 on iafork:fix_tox into 8d592a2 on RDFLib:master.

The current tox config does not work as the dependencies are out of sync
and doctest has troubles with xunit.

This fixes it so that tox works again and makes it easier for other
people to contribute.
Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me but please accept my PR to your branch first which updates the tox supported Python versions which should now be 3.6, - 3.9 only. Thanks.

Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, in addition to my Python version update, please remove space between -r and requirements files, as per StackOverflow

aucampia added 2 commits May 16, 2021 12:26
update supported Python versions
As @nicholascar pointed out this causes problems in some cases.
@aucampia aucampia requested a review from nicholascar May 16, 2021 10:31
@aucampia
Copy link
Member Author

Actually, in addition to my Python version update, please remove space between -r and requirements files, as per StackOverflow

Changed it as requested, thanks for the heads up :)

@nicholascar
Copy link
Member

@white-gecko @ashleysommer over to you. Looks good to me

@nicholascar nicholascar merged commit a32f48b into RDFLib:master Jun 19, 2021
@aucampia aucampia deleted the fix_tox branch November 17, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox not working
3 participants