Fix SPARQL update parsing to handle arbitrary amounts of triples in inserts #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-issue1336
branch
from
873da0c to
3d1941a
Compare
aucampia
changed the title
aucampia
force-pushed
the
iwana-issue1336
branch
from
3d1941a to
5df0a36
Compare
aucampia
force-pushed
the
iwana-issue1336
branch
from
5df0a36 to
9e92d7c
Compare
…nserts pyparsing handling of recursive rules is limited by python's recursion limit and the rule that should handle multiple triples in data inserts is recursive. The consequence of this is that the amount of triples that can be inserted becomes limited by python's recursion limit. To address this the rule has been rewritten to not be recursive. @rchateauneu thanks for the help with rule rewriting.
aucampia
force-pushed
the
iwana-issue1336
branch
from
9e92d7c to
187a4e2
Compare
rchateauneu
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyparsing handling of recursive rules is limited by python's recursion limit
and the rule that should handle multiple triples in data inserts is
recursive.
The consequence of this is that the amount of triples that can be
inserted becomes limited by python's recursion limit.
To address this the rule has been rewritten to not be recursive.
@rchateauneu thanks for the help with rule rewriting.
Fixes #1336
Proposed Changes
@unittest.expectedFailure[52] TriplesTemplate ::= TriplesSameSubject ( '.' TriplesTemplate? )?toTriplesTemplate ::= TriplesSameSubject ( '.' TriplesSameSubject? )*so it is not recursive.