Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format whole *.py codes #1687

Closed
wants to merge 2 commits into from
Closed

Format whole *.py codes #1687

wants to merge 2 commits into from

Conversation

eggplants
Copy link
Contributor

@eggplants eggplants commented Jan 24, 2022

Ref: #1159, #1589

Proposed Changes

I just ran this in the project root: $ black . && isort .

@ashleysommer
Copy link
Contributor

Hi @eggplants
We usually encourage all PRs to run black on their code before merging, and we regularly check the whole codebase with the black style check in our github actions. So the whole codebase should already be formatted according to our black rules, and should not need to be changed.

We do not currently use isort in this project. I agree it is a good tool, and I use it in several of my personal projects. If we started using it in RDFLib, it would be gradually, starting with only new code and new PRs. There is a lot of very old code in RDFLib (going back to 2001) that has not been touched in years, there is no need to run isort over every source file.

@eggplants eggplants deleted the format branch January 24, 2022 05:17
@eggplants eggplants mentioned this pull request Jan 24, 2022
@eggplants
Copy link
Contributor Author

@ashleysommer OK, I resubmitted PR.

@eggplants eggplants mentioned this pull request Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants