Use the property built-in as a decorator
#1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220130T2327-modern_property
branch
from
8cb5df8 to
0d2c762
Compare
|
Actually I'm going to add more tests first, all lines are covered by tests but there are no explicit tests for these properties. |
aucampia
force-pushed
the
iwana-20220130T2327-modern_property
branch
3 times, most recently
from
ca12e19 to
ca6ae6e
Compare
added now. |
aucampia
force-pushed
the
iwana-20220130T2327-modern_property
branch
from
ca6ae6e to
6fd0857
Compare
aucampia
added
review wanted
The use of the `property` built-in as a function does not allow for the same type annotations as using `property` as a decorator. This change should not affect runtime behaviour, but I added tests to cover all properties that were changed to decorators explicitly just to make sure they work as they should. There are still other places where the `property` built-in is used as a function but this is outside of the core parts of RDFLib.
aucampia
force-pushed
the
iwana-20220130T2327-modern_property
branch
from
6fd0857 to
f0a16af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the
propertybuilt-in as a function does not allow forthe same type annotations as using
propertyas a decorator.This change should not affect runtime behaviour, but I added tests to
cover all properties that were changed to decorators explicitly just to
make sure they work as they should.
There are still other places where the
propertybuilt-in is used as afunction but this is outside of the core parts of RDFLib.
For some context, I'm busy adding typing to store/queries and without this things get a bit hairy. I'm doing this separately as this goes beyond simple addition of type annotations, and as such want this to stand on it's own to make it easier to review and asses.