Fix flake8 errors #1762
Closed
Fix flake8 errors #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Type fixes are already made here: https://github.com/RDFLib/rdflib/pull/1759/files Review welcome, but I'm not going to review another PR that makes the same changes after the time I already spent on it. Please try and keep PRs limited in scope. I will make a PR to add some guidelines on PRs once I have time, but in brief, if a PR can be split up into multiple PRs, it should be. We have limited time for reviews and the bigger a PR the longer it will take to get a review. We have a massive review backlog also, and it is hard to justify reviewing one PR that is too big compared to another one that is too big. If the PR is small in scope and includes tests for all runtime changes it makes it very easy for us to review and accept. |
aucampia
reviewed
Mar 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flake8 errors for passing CI.