Migrate more tests to pytest #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
reviewed
Apr 12, 2022
aucampia
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Thanks @gjhiggins - PR looks great, and as easy to review as such a thing can be. Will merge tomorrow morning (CET) if there is no further feedback.
aucampia
approved these changes
Apr 12, 2022
aucampia
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Continued migration of unittests to pytest. I've changed my approach to follow @aucampia's lead, acknowledging that retaining the UnitTest class structure makes changes far more readily apparent. We're not done with test re-org yet (blacking in prospect) so the UnitTest structure can be removed at a later stage.
Checklist
so maintainers can fix minor issues and keep your PR up to date.