Added test for example at CBD definition. Fixes #1914. #1915

asejal · 2022-05-12T18:17:47Z

Fixes #1914

Summary of changes

We have added a test for the example at the definition for Concise Bounded Definition here. It has been converted to turtle format for uniformity.

For the given RDF graph as input:

Expected output for CBD of http://example.com/aReallyGreatBook corresponds to the following subgraph:

The test passes.
In collaboration with @ms1901.

asejal · 2022-05-12T18:22:16Z

pre-commit.ci autofix

for more information, see https://pre-commit.ci

coveralls · 2022-05-12T18:39:07Z

Coverage remained the same at 88.248% when pulling ce07700 on asejal:master into 5e5dcea on RDFLib:master.

aucampia · 2022-05-12T18:56:24Z

test/test_graph/test_graph_cbd.py

+    # add example from Concise Bounded Description definition at https://www.w3.org/Submission/CBD/#example
+    g.parse(


This should be in a separate test function.

aucampia · 2022-05-12T19:01:57Z

test/test_graph/test_graph_cbd.py

+            PREFIX ex:    <http://ex/>
+            PREFIX dct:   <http://purl.org/dc/terms/>
+            PREFIX rdf:   <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
+            PREFIX owl:   <http://www.w3.org/2002/07/owl#>
+            PREFIX xsd:   <http://www.w3.org/2001/XMLSchema#>
+            PREFIX rdfs:  <http://www.w3.org/2000/01/rdf-schema#>
+            PREFIX foaf:  <http://xmlns.com/foaf/0.1/>
+            PREFIX dc:    <http://purl.org/dc/elements/1.1/>
+
+            ex:aBookCritic  ex:dislikes  ex:anotherGreatBook ;
+                    ex:likes     ex:aReallyGreatBook .
+
+            [ a                 rdf:Statement ;
+            rdf:object        "image/jpeg" ;
+            rdf:predicate     dc:format ;
+            rdf:subject       foaf:Image ;
+            rdfs:isDefinedBy  ex:image-formats.rdf
+            ] .
+
+            foaf:mbox  a    owl:InverseFunctionalProperty , rdf:Property .
+
+            [ a                 rdf:Statement ;
+            rdf:object        "application/pdf" ;
+            rdf:predicate     dc:format ;
+            rdf:subject       ex:aReallyGreatBook ;
+            rdfs:isDefinedBy  ex:book-formats.rdf
+            ] .
+
+            ex:aReallyGreatBook  rdfs:seeAlso  ex:anotherGreatBook ;
+                    dc:contributor  [ a          foaf:Person ;
+                                    foaf:name  "Jane Doe"
+                                    ] ;
+                    dc:creator      [ a           foaf:Person ;
+                                    foaf:img    ex:john.jpg ;
+                                    foaf:mbox   "[email protected]" ;
+                                    foaf:name   "John Doe" ;
+                                    foaf:phone  <tel:+1-999-555-1234>
+                                    ] ;
+                    dc:format       "application/pdf" ;
+                    dc:language     "en" ;
+                    dc:publisher    "Examples-R-Us" ;
+                    dc:rights       "Copyright (C) 2004 Examples-R-Us. All rights reserved." ;
+                    dc:title        "A Really Great Book" ;
+                    dct:issued      "2004-01-19"^^xsd:date .
+
+            ex:anotherGreatBook  rdfs:seeAlso  ex:aReallyGreatBook ;
+                    dc:creator    "June Doe ([email protected])" ;
+                    dc:format     "application/pdf" ;
+                    dc:language   "en" ;
+                    dc:publisher  "Examples-R-Us" ;
+                    dc:rights     "Copyright (C) 2004 Examples-R-Us. All rights reserved." ;
+                    dc:title      "Another Great Book" ;
+                    dct:issued    "2004-05-03"^^xsd:date .
+
+            ex:john.jpg  a     foaf:Image ;
+                    dc:extent  "1234" ;
+                    dc:format  "image/jpeg" .


I would prefer this rather go into a file in test/data/spec/cbd/example_graph.rdf as RDF XML (i.e. identical to what is here) and then place the "concise bounded description of http://example.com/aReallyGreatBook" in test/data/spec/cbd/example_graph_cbd.rdf

aucampia · 2022-05-12T19:04:30Z

test/test_graph/test_graph_cbd.py

+    assert len(g.cbd(EX.aReallyGreatBook)) == (
+        21
+    ), "cbd() for aReallyGreatBook should return 21 triples"


This is not sufficent, this should check that the resulting graph from Graph.cbd is isomorphic to and identical to (when discarding triples) the graph given in https://www.w3.org/Submission/CBD/#example

To do this you can use

GraphHelper.assert_isomorphic and GraphHelper.assert_sets_equals(..., exclude_blanks=True) for this.

Thank you for the review.
We have completed the above requirements. We have created a separate function for testing the CBD example along with all the above mentioned asserts, and also added two separate data files.

aucampia

Thank you very much for having a look at this @asejal - though please see the feedback.

asejal · 2022-05-12T20:46:06Z

pre-commit.ci autofix

for more information, see https://pre-commit.ci

aucampia · 2022-05-12T20:46:51Z

test/test_graph/test_graph_cbd.py

+EXAMPLE_GRAPH_FILE_PATH = os.path.join(*[TEST_DATA_DIR, "spec", "cbd", "example_graph.rdf"])
+EXAMPLE_GRAPH_CBD_FILE_PATH = os.path.join(*[TEST_DATA_DIR, "spec", "cbd", "example_graph_cbd.rdf"])


This is causing some failure:

test/test_graph/test_graph_cbd.py:9: error: No overload variant of "join" matches argument type "List[object]" [call-overload] test/test_graph/test_graph_cbd.py:9: note: Possible overload variants: test/test_graph/test_graph_cbd.py:9: note: def join(__a, Union[str, PathLike[str]], *paths: Union[str, PathLike[str]]) -> str test/test_graph/test_graph_cbd.py:9: note: def join(__a, Union[bytes, PathLike[bytes]], *paths: Union[bytes, PathLike[bytes]]) -> bytes test/test_graph/test_graph_cbd.py:10: error: No overload variant of "join" matches argument type "List[object]" [call-overload] test/test_graph/test_graph_cbd.py:10: note: Possible overload variants: test/test_graph/test_graph_cbd.py:10: note: def join(__a, Union[str, PathLike[str]], *paths: Union[str, PathLike[str]]) -> str test/test_graph/test_graph_cbd.py:10: note: def join(__a, Union[bytes, PathLike[bytes]], *paths: Union[bytes, PathLike[bytes]]) -> bytes Found 2 errors in 1 file (checked 299 source files)

The following should work:

Suggested change

EXAMPLE_GRAPH_FILE_PATH = os.path.join(*[TEST_DATA_DIR, "spec", "cbd", "example_graph.rdf"])

EXAMPLE_GRAPH_CBD_FILE_PATH = os.path.join(*[TEST_DATA_DIR, "spec", "cbd", "example_graph_cbd.rdf"])

EXAMPLE_GRAPH_FILE_PATH = TEST_DATA_DIR / "spec" / "cbd" / "example_graph.rdf"

EXAMPLE_GRAPH_CBD_FILE_PATH = TEST_DATA_DIR / "spec" / "cbd" / "example_graph_cbd.rdf"

aucampia

Looks very good now, just some issue with the Paths.

aucampia · 2022-05-12T20:59:01Z

test/test_graph/test_graph_cbd.py

@@ -109,3 +122,21 @@ def testCbdReified(get_graph):
    )

    assert len(g.cbd(EX.R6)) == (3 + 5 + 5), "cbd() for R6 should return 12 triples"
+
+
+def testCbdExample():


Suggested change

def testCbdExample():

def test_cbd_example():

Function names should conform to PEP8[ref]:

https://peps.python.org/pep-0008/#function-and-variable-names

Function names should be lowercase, with words separated by underscores as necessary to improve readability.

asejal · 2022-05-12T21:02:27Z

pre-commit.ci autofix

for more information, see https://pre-commit.ci

aucampia

Thanks @asejal - very happy to have this in place.

aucampia · 2022-05-12T21:22:29Z

Will wait for some more feedback but as this is just adding a test I think it is fine with one review, so I will merge it tomorrow unless there is more feedback.

ghost

lgtm

asejal · 2022-05-13T15:44:21Z

Hi @aucampia, since the pull request has been approved will it be possible for you to merge it? Thanks.

Added test for example at CBD definition

4eb45ab

[pre-commit.ci] auto fixes from pre-commit.com hooks

acb4673

for more information, see https://pre-commit.ci

aucampia reviewed May 12, 2022

View reviewed changes

Added separate function for testing example graph

2eed301

[pre-commit.ci] auto fixes from pre-commit.com hooks

642e0c6

for more information, see https://pre-commit.ci

aucampia reviewed May 12, 2022

View reviewed changes

Updated function name and path

35f3218

[pre-commit.ci] auto fixes from pre-commit.com hooks

ce07700

for more information, see https://pre-commit.ci

aucampia approved these changes May 12, 2022

View reviewed changes

aucampia requested a review from a team May 12, 2022 21:10

aucampia added the review wanted This indicates that the PR is ready for review label May 12, 2022

ghost approved these changes May 13, 2022

View reviewed changes

aucampia approved these changes May 13, 2022

View reviewed changes

aucampia merged commit e5f3f1f into RDFLib:master May 13, 2022

ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added test for example at CBD definition. Fixes #1914. #1915

Added test for example at CBD definition. Fixes #1914. #1915

asejal commented May 12, 2022

asejal commented May 12, 2022 •

edited

Loading

coveralls commented May 12, 2022 •

edited

Loading

aucampia May 12, 2022

aucampia May 12, 2022 •

edited

Loading

aucampia May 12, 2022

asejal May 12, 2022

aucampia left a comment

asejal commented May 12, 2022

aucampia May 12, 2022

aucampia left a comment

aucampia May 12, 2022

asejal commented May 12, 2022

aucampia left a comment

aucampia commented May 12, 2022

ghost left a comment

asejal commented May 13, 2022

		# add example from Concise Bounded Description definition at https://www.w3.org/Submission/CBD/#example
		g.parse(

		EXAMPLE_GRAPH_FILE_PATH = os.path.join(*[TEST_DATA_DIR, "spec", "cbd", "example_graph.rdf"])
		EXAMPLE_GRAPH_CBD_FILE_PATH = os.path.join(*[TEST_DATA_DIR, "spec", "cbd", "example_graph_cbd.rdf"])

Added test for example at CBD definition. Fixes #1914. #1915

Added test for example at CBD definition. Fixes #1914. #1915

Conversation

asejal commented May 12, 2022

Summary of changes

asejal commented May 12, 2022 • edited Loading

coveralls commented May 12, 2022 • edited Loading

aucampia May 12, 2022

Choose a reason for hiding this comment

aucampia May 12, 2022 • edited Loading

Choose a reason for hiding this comment

aucampia May 12, 2022

Choose a reason for hiding this comment

asejal May 12, 2022

Choose a reason for hiding this comment

aucampia left a comment

Choose a reason for hiding this comment

asejal commented May 12, 2022

aucampia May 12, 2022

Choose a reason for hiding this comment

aucampia left a comment

Choose a reason for hiding this comment

aucampia May 12, 2022

Choose a reason for hiding this comment

asejal commented May 12, 2022

aucampia left a comment

Choose a reason for hiding this comment

aucampia commented May 12, 2022

ghost left a comment

Choose a reason for hiding this comment

asejal commented May 13, 2022

asejal commented May 12, 2022 •

edited

Loading

coveralls commented May 12, 2022 •

edited

Loading

aucampia May 12, 2022 •

edited

Loading