Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address lingering instances of deprecated tempfile.mktemp #1942

Merged
merged 2 commits into from May 15, 2022
Merged

Address lingering instances of deprecated tempfile.mktemp #1942

merged 2 commits into from May 15, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 15, 2022

Summary of changes

Updated two instances of lingering deprecated tempfile.mktemp usage to use current safe tempfile idiom.

Checklist

  • Checked that there aren't other open pull requests for the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@ghost ghost self-requested a review May 15, 2022 13:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

aucampia
aucampia approved these changes May 15, 2022
View reviewed changes
Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, it may be a bit simpler to use the tmp_path but already an improvement. Will merge a bit later tonight.

@coveralls
Copy link

coveralls commented May 15, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 88.395% when pulling cf41ab2 on gjhiggins:fix-bdb-tmpfile-vuln into ab23b62 on RDFLib:master.

@ghost
Copy link
Author

ghost commented May 15, 2022

it may be a bit simpler to use the tmp_path

noted

@aucampia aucampia merged commit 8a096ab into RDFLib:master May 15, 2022
@ghost ghost deleted the fix-bdb-tmpfile-vuln branch May 15, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coveralls @aucampia @gjhiggins