-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sonarcloud-reported bug in xmlwriter, add test #1951
Conversation
“Remove 1 unexpected arguments; 'join' expects 1 positional arguments.”
This might be getting a bit out of hand
|
But should these not be globals anyway? They look the same in all test functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice with 100% test coverage.
Will merge by 2022-05-25 if there is no further feedback. |
pre-commit.ci autofix |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Summary of changes
sonarcloud detected a bug: “Remove 1 unexpected arguments; 'join' expects 1 positional arguments.” in xmlwriter:
Added containing brackets apparently omitted by original author.
Added test for surety, took the opportunity of adding two tests to take coverage of
xmlwriter
to 100%.Checklist
so maintainers can fix minor issues and keep your PR up to date.