-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: rework SPARQL test suite #1988
test: rework SPARQL test suite #1988
Conversation
2aef2ea
to
3267043
Compare
Check that EARL report matches pytest report:
|
e7b4dac
to
87e4578
Compare
This patch reworks the SPARQL test suite to use the new DAWG manifest processor. The actual checker is also more accurate, correctly reporting negative tests and more correctly checking the resutls of positive tests. There are still some tests from the SPARQL test suite that are not executed, but checkers for these will be implemented later. Other changes: - Fixed `test/data/suites/rdflib/sparql/unicode.srx`. This file did not have the correct content for the query. I verified this with Apache Jena.
87e4578
to
c6a0a09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rockin'
@@ -0,0 +1,128 @@ | |||
""" | |||
Runs the SPARQL 1.0 test suite from. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aucampia - whoops, looks like a citation was truncated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT, the relevant (resolvable) URL is https://www.w3.org/2001/sw/DataAccess/tests/data-r2
Summary of changes
This patch reworks the SPARQL test suite to use the new DAWG manifest
processor. The actual checker is also more accurate, correctly reporting
negative tests and more correctly checking the results of positive
tests.
Some of the tests that were not executed before are still
being skipped, but they will now correctly report as skipped.
Other changes:
test/data/suites/rdflib/sparql/unicode.srx
. This file did nothave the correct content for the query. I verified this with Apache Jena.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.