Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infixowl coverage ii #2024

Merged
merged 17 commits into from Jul 17, 2022
Merged

Infixowl coverage ii #2024

merged 17 commits into from Jul 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 15, 2022

Summary of changes

Final stage of update to infixowl, removing unused code, tidying, adding some docucomments, minor improvements in robustness, updating previously-failing tests, adding more tests. Expanded documentation to follow.

Checklist

  • Checked that there aren't other open pull requests for the same change.
  • Added tests for any changes that have a runtime impact.
  • Checked that all tests and type checking passes.
  • For changes that have a potential impact on users of this project:
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
    • Considered adding an example in ./examples for new features.
    • Considered updating our changelog (CHANGELOG.md).
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@coveralls
Copy link

coveralls commented Jul 15, 2022

Coverage Status

Coverage increased (+0.08%) to 90.444% when pulling 908aa92 on gjhiggins:infixowl-coverage-ii into 81b36e2 on RDFLib:master.

rdflib/extras/infixowl.py Outdated Show resolved Hide resolved
@aucampia
Copy link
Member

@gjhiggins looks good, but I'm going to add release notes also.

Copy link
Member

@aucampia aucampia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, please have a look at the changes I included for readme and the exception to see if you are fine with it.

@aucampia aucampia requested a review from a team July 16, 2022 21:42
@ghost
Copy link
Author

ghost commented Jul 17, 2022

Changes look good to me, please have a look at the changes I included for readme and the exception to see if you are fine with it.

Yep, fine by me. Extended documentation to come (honest, guv)

@aucampia aucampia merged commit 40eaa26 into RDFLib:master Jul 17, 2022
@ghost ghost deleted the infixowl-coverage-ii branch July 17, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants