Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Gitpod integration and Google Cloud Shell Button #2034

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Jul 17, 2022

Summary of changes

Add Gitpod integration mainly intended to make it easier for
contributors to work with RDFLib.

Other changes:

  • Add a button for Google cloud shell integration, it is maybe not as
    nice as Gitpod but it provides a lot more free hours than Gitpod and it
    does work with the devcontainer based workflow even if the editor does
    not integrate with devcontainers directly.
  • Removed additional python versions from the devcontainer dockerfile.
    This is mainly to make the devcontainer less unwieldy and quicker to
    build.
  • Slim down the devcontainer Dockerfile by removing some unneeded
    packages, this will make it faster to build.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia force-pushed the iwana-20220717T1844-gitpod branch from 21ce2f9 to a56b6e6 Compare July 17, 2022 21:24
@gitpod-io
Copy link

gitpod-io bot commented Jul 17, 2022

@coveralls
Copy link

coveralls commented Jul 17, 2022

Coverage Status

Coverage remained the same at 90.446% when pulling 926ce27 on aucampia:iwana-20220717T1844-gitpod into fda98ec on RDFLib:master.

@aucampia aucampia force-pushed the iwana-20220717T1844-gitpod branch 13 times, most recently from 972559c to 978c85e Compare July 18, 2022 17:43
Add Gitpod integration mainly intended to make it easier for
contributors to work with RDFLib and also to get CI validation of
`Dockerfile.devcontainer`.

Other changes:

- Add a button for Google cloud shell integration, it is maybe not as
  nice as Gitpod but it provides a lot more free hours than Gitpod and it
  does work with the devcontainer based workflow even if the editor does
  not integrate with devcontainers directly.
- Removed additional python versions from the devcontainer dockerfile.
  This is mainly to make the devcontainer less unwieldy and quicker to
  build.
- Slim down the devcontainer Dockerfile by removing some uneeded
  packages, this will make it faster to build.
@aucampia aucampia force-pushed the iwana-20220717T1844-gitpod branch from 3873295 to 926ce27 Compare July 18, 2022 21:37
@aucampia aucampia marked this pull request as ready for review July 19, 2022 16:57
@aucampia aucampia requested a review from a team July 19, 2022 16:58
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@aucampia aucampia merged commit 93963ee into RDFLib:master Jul 20, 2022
@aucampia aucampia deleted the iwana-20220717T1844-gitpod branch July 21, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants