Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: convert some unittest based tests to pytest #2075

Merged
merged 1 commit into from
Aug 7, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Aug 5, 2022

Summary of changes

Fairly straight forward conversion, converted one skip to an xfail
though with an explanation of what is going wrong.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

Fairly straight forward conversion, converted one skip to an xfail
though with an explanation of what is going wrong.
@aucampia aucampia marked this pull request as ready for review August 5, 2022 22:00
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.447% when pulling 20181c5 on aucampia:iwana-20220805T2353-more_pytest into cc80c9c on RDFLib:master.

@aucampia aucampia requested a review from a team August 6, 2022 09:08
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aucampia aucampia merged commit 131d9e6 into RDFLib:master Aug 7, 2022
@aucampia aucampia deleted the iwana-20220805T2353-more_pytest branch April 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants