test: make graph variant tests more granular #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fail because of: |
aucampia
force-pushed
the
aucampia/20230817T0007-test_variants
branch
2 times, most recently
from
5970880 to
7c2f2a2
Compare
The graph variant tests were checking all variants in one test, so if one format had issues, the whole variant was failing. The result was overly broad xfails. This change splits the variant tests up into separate tests for each variant. This change is made in preparation for adding Python based Graph variants.
aucampia
force-pushed
the
aucampia/20230817T0007-test_variants
branch
from
7c2f2a2 to
b3afe18
Compare
aucampia
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The graph variant tests were checking all variants in one test, so if one format had issues, the whole variant was failing. The result was overly broad xfails.
This change splits the variant tests up into separate tests for each variant.
This change is made in preparation for adding Python based Graph variants.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.