-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hextuple parser and serializer now supports anonymous graph names #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is some precursor work on parsers to support skolemization at parse time. |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
This reverts commit 78106bb.
There seems to be some linting/styling differences with the precommit autofix and the gha:lint rules for ruff. |
Merged
8 tasks
ashleysommer
approved these changes
Jul 24, 2024
This looks good, tests are fine and tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add support for the handling of anonymous graph names in the hextuple parser and serializer.
The previous behaviour always treated the sixth value in the tuple as the IRI of the graph name. However, as per the hextuples spec,
This new behaviour now inspects the start of the value and, if it sees
_:
, it will treat it as a blank node.Tests have been added and updated to adjust for this change, including the testing of roundtripping the hextuple format.
Checklist
the same change.
./examples
.so maintainers can fix minor issues and keep your PR up to date.