-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial implementation of RDF Patch parser. #2863
Add initial implementation of RDF Patch parser. #2863
Conversation
ca0c921
to
e219665
Compare
… if self.line is None in the first place.
@edmondchuc Merging is blocked on your pending review. Can you please re-review and approve to so we can merge it. |
) | ||
# type error: Incompatible types in assignment (expression has type "ConjunctiveGraph", base class "W3CNTriplesParser" defined the type as "Union[DummySink, NTGraphSink]") | ||
self.sink: Dataset = Dataset(store=sink.store) | ||
self.skolemize = skolemize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And can remove these now after the changes in 0e75969?
Probably doesn't affect anything since it defaults to False in the super class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I just mirrored the other parsers here. Could there be use cases where someone wants to skolemize when parsing?
Summary of changes
Introduces support for parsing RDF Patch files, aligned to the specification here: https://afs.github.io/rdf-delta/rdf-patch.html
Supports:
blank nodes can be specified either using the format:
_:identifier
<_:identifier>
both will be parsed as blank nodes and their identifier from the document they are parsed from preserved.
Known limitations:
Checklist
the same change.
Created an issue to discuss the change and get in-principle agreement.Discussed with a number of maintainersTODO:
./examples
.