In .patch serializer, default to "add" operation if no operation #2898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RDF
.patch
serializer, default to"add"
operation if no operation or notarget
(diff) is given inkwargs
.This is because not all serializing codepaths allow passing
kwargs
.This fixes the testsuite integration and allows round-trip tests to complete successfully with the
.patch
serializer.I believe it is reasonable to expect that a user naively serializing their Graph to
.patch
format would want to default toadd
operation if no operation is given. In current implementation, nooperation
and notarget
results in a.patch
file with only a header and no contents. This is considered a no-op file, and is likely not what the user wants.Fixes the issue discussed at the bottom of #2877