Replace deprecated method in csv2rdf #2901
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #2618.
The code for tne
csv2rdf
command-line tool callsConfigParser.readfp
, which has been deprecated for a while and has been removed in Python 3.12. Theread_file
method is a straightforward replacement.I have checked manually that the old and new version give the same result for a sample config file.
I've also taken the opportunity to add another small test, since the coverage for that tool is quite low. The new test doesn't check that the contents of the config file are processed correctly, only that it is opened.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.