Replace html5lib with html5rdf, make it an optional dependency #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
html support is now optional again, and it uses html5rdf rather than html5lib/html5lib-modern.
This reverts commit 6f80ad9cd2cc4b76ff4e1bc0998951768aff7573.
…mage can be built with the released rdflib v7.1.0
… used vs when it is not used.
ashleysommer
force-pushed
the
html5rdf
branch
from
191dce3 to
c32fcbc
Compare
ashleysommer
changed the title
|
@nicholascar @edmondchuc |
nicholascar
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit undoes some of what was merged in the v7.1 release that made HTML tokenisation of rdf:HTML literals non-optional.
This makes it an optional extra feature of RDFLib again, and moves away from using the deprecated html5lib (and the alias replacement html5-modern), to using the new html5rdf that lives in the RDFLib org.
This also fixes the tests that comparison code paths that were crashing, that was the reason for making HTML tokenisation non-optional in v7.1. Now that these are fixed, its safe to not have html5rdf installed when using RDFLib.