Fixed bnode collision bug.

[jpmccu]

Fix for #494.

[joernhees]

sorry for not spotting this one before :-/

could also be written as new_color.append((len(color.nodes),)), which is a bit faster, but maybe premature optimization:

In [1]: %timeit tuple([1337])
The slowest run took 5.53 times longer than the fastest. This could mean that an intermediate result is being cached
1000000 loops, best of 3: 345 ns per loop

In [2]: %timeit (1337,)
The slowest run took 47.08 times longer than the fastest. This could mean that an intermediate result is being cached
10000000 loops, best of 3: 25.3 ns per loop

[wwaites]

On Mon, 10 Aug 2015 10:33:29 -0700, Jörn Hees [email protected] said:

> could also be written as
> `new_color.append((len(color.nodes),))`, which is a bit faster,
> but maybe premature optimization:

Creating a value with the right datatype instead of creating one with
the wrong datatype and then converting it isn't optimisation, it's
just doing things correctly.

Or so I think anyways...

-w

[jpmccu]

I wouldn't object to the change. I couldn't remember the syntax for a single-element tuple.

[joernhees]

@wwaites: well, the double bracket removal is one of the tripping stones in python, so i can somehow understand why some people prefer (tuple([...])) instead of ((...,)). Without seeing it as much of a problem i still changed it in b8df01f ;)