Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr 451 redux #978

Merged
merged 9 commits into from
Mar 28, 2020
Merged

Pr 451 redux #978

merged 9 commits into from
Mar 28, 2020

Conversation

nicholascar
Copy link
Member

@nicholascar nicholascar commented Mar 19, 2020 •
edited by white-gecko
Loading

A re-implementation of PR #451 because I don't believe the fix posed there addresses all conceivable add() scenarios.

This is failing to pass all my new tests and needs work with double/float rounding to get there.

@nicholascar nicholascar added the bug Something isn't working label Mar 19, 2020
@nicholascar nicholascar added this to the rdflib 5.0.0 milestone Mar 19, 2020
@nicholascar nicholascar self-assigned this Mar 19, 2020
@nicholascar
Copy link
Member Author

i.e. passing all numeric tests: now it's failing an XML Literal test!

@nicholascar nicholascar mentioned this pull request Mar 23, 2020
Closed
@coveralls
Copy link

coveralls commented Mar 23, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 75.888% when pulling f01effe on pr_451_redux into 31fb707 on master.

@ashleysommer
Copy link
Contributor

@nicholascar
I'm just doing a couple of my own tests locally against this, then I'll approve it to merge in before our release.

ashleysommer
ashleysommer approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@ashleysommer ashleysommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new logic is working great!

@ashleysommer ashleysommer merged commit 2aebbf0 into master Mar 28, 2020
@nicholascar nicholascar deleted the pr_451_redux branch March 28, 2020 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleysommer ashleysommer ashleysommer approved these changes

@white-gecko white-gecko Awaiting requested review from white-gecko

Assignees

@nicholascar nicholascar

Labels
bug Something isn't working
Projects
None yet
Milestone
rdflib 5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholascar @coveralls @ashleysommer