Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Updating whole of source code #361

Closed
wants to merge 7 commits into from
Closed

WIP: Updating whole of source code #361

wants to merge 7 commits into from

Conversation

Ikuyadeu
Copy link
Member

@Ikuyadeu Ikuyadeu commented Jun 16, 2020

What problem did you solve?

  • Fix for the new eslint rules (Now in progress)
    Current style plugin:@typescript-eslint/eslint-recommended was suitable for JavaScript.
    I add the other extends

  • eslint:recommended: Same with 'plugin:@typescript-eslint/eslint-recommended'

  • plugin:@typescript-eslint/recommended: Recommended rules for the TypeScript

  • Refactor session.ts
    Current session.ts has too many global values,

export let globalenv: any;
let resDir: string;
let watcherDir: string;
let requestFile: string;
let requestLockFile: string;
let requestTimeStamp: number;
let sessionDir: string;
let pid: string;
let globalenvFile: string;
let globalenvLockFile: string;
let globalenvTimeStamp: number;
let plotView: string;
let plotFile: string;
let plotLockFile: string;
let plotTimeStamp: number;
let plotDir: string;
let requestWatcher: FSWatcher;
let globalEnvWatcher: FSWatcher;
let plotWatcher: FSWatcher;

to help code understanding, it should be included in the function declaration.

  • Clean up extension.ts

Current extension.ts has many functions like getBracketCompletionItems.
They should be each other files, and extension.ts will just call them.
Personally, break loop1; is not good for understanding code flows. it can be more easily.

Unfortunately, I do not have enough knowledge for the R, so I will not touch init.R in this PR.

@Ikuyadeu
Copy link
Member Author

Instead of eslint, I added super-linter it is published as the GitHub officially.

@Ikuyadeu
Copy link
Member Author

Duplicated with #474

@Ikuyadeu Ikuyadeu closed this Nov 29, 2020
Ikuyadeu added a commit that referenced this pull request Nov 30, 2020
* fix whole of style

* apply eslint on test code

* assert.equal to assert.strictEqual

* update DevReplay rule
@Ikuyadeu Ikuyadeu deleted the new_style branch November 30, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant