WIP: Updating whole of source code #361
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Fix for the new eslint rules (Now in progress)
Current style
plugin:@typescript-eslint/eslint-recommended
was suitable for JavaScript.I add the other extends
eslint:recommended
: Same with 'plugin:@typescript-eslint/eslint-recommended'plugin:@typescript-eslint/recommended
: Recommended rules for the TypeScriptRefactor
session.ts
Current
session.ts
has too many global values,to help code understanding, it should be included in the function declaration.
extension.ts
Current
extension.ts
has many functions likegetBracketCompletionItems
.They should be each other files, and
extension.ts
will just call them.Personally,
break loop1;
is not good for understanding code flows. it can be more easily.Unfortunately, I do not have enough knowledge for the R, so I will not touch
init.R
in this PR.