Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension for receiving WMBus messages #1281

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Extension for receiving WMBus messages #1281

merged 6 commits into from
Jan 6, 2025

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)
    No processing of WMBus messages, see no DISPATCH from WMBUS Msg´s - Software extension for WMBUS #1247

  • What is the new behavior (if this is a feature change)?
    Reception of WMBus messages possible (in conjunction with the extension of the SIGNALduino firmware).

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@elektron-bbs
Copy link
Contributor Author

elektron-bbs commented Nov 10, 2024

Einige Tests laufen jetzt nicht mehr durch. Ich weiß allerdings nicht, wo ich da ansetzen muss.

EDIT:
Die Tests wurden jetzt angepasst und laufen jetzt durch.

@elektron-bbs elektron-bbs requested a review from sidey79 November 10, 2024 19:59
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.80%. Comparing base (05e90de) to head (4a3fb69).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
FHEM/00_SIGNALduino.pm 72.22% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1281      +/-   ##
==========================================
+ Coverage   76.09%   84.80%   +8.70%     
==========================================
  Files          95      139      +44     
  Lines        8797    10318    +1521     
  Branches     1684     1692       +8     
==========================================
+ Hits         6694     8750    +2056     
+ Misses       2102     1567     -535     
  Partials        1        1              
Flag Coverage Δ
fhem 76.95% <72.22%> (+0.86%) ⬆️
modules 84.80% <72.22%> (+8.70%) ⬆️
perl 95.25% <ø> (?)
unittests 84.80% <72.22%> (+8.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elektron-bbs
Copy link
Contributor Author

Zuerst möchte ich allen ein gesundes und erfolgreiches neues Jahr 2025 wünschen.

@sidey79
Dieser PR müsste auch noch bestätigt werden, damit WM-Bus ermöglicht wird.

Es wäre auch nicht schlecht, wenn du von der SIGNALduino-Firmware ein neues Release veröffentlichst. Das letzte öffentliche 3.5.1 ist vom Juni 2023.
Ich denke, der Einbau von WM-Bus rechtfertigt jetzt einen Sprung auf Version 4.0.0.

@elektron-bbs elektron-bbs merged commit 239ad5e into master Jan 6, 2025
18 checks passed
@elektron-bbs elektron-bbs deleted the master_WMBus branch February 7, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants