Make sure linked text is accounted for #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcritch
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entries with "Yes" in the "on prio-list" weren't showing up when selecting "Cases on Prio-list or Watchlist or Crit Sit" from the "Escalated?" drop-down menu. This was because some of the entries were hyperlinked (
<a href="example.com">Yes</a>) - our code was only checking if therow == "Yes", so I've changed it to look for code that includes "Yes". Now it will match rows where the entry is "Yes", as well as rows where the entry is"<a href='example.com'>Yes</a>".I've also started a running list in CONTRIBUTING.md with some tips to help debug issues.