Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing sonar and linting issues, part 1 #295

Merged
merged 3 commits into from
Jul 29, 2024
Merged

fixing sonar and linting issues, part 1 #295

merged 3 commits into from
Jul 29, 2024

Conversation

dcritch
Copy link
Contributor

@dcritch dcritch commented Jul 24, 2024

fixes around 10 sonar findings:

  • variable shadows a builtin
  • rename camelCase vars
  • use \d instead of [0-9] in regex
  • don't use datetime.datetime.utcnow()
  • duplicated literals: rather than define constants, break out make_header and format_date functions for reuse

plus a couple of pylint findings.

@dcritch dcritch requested a review from adhil0 July 24, 2024 19:39
adhil0
adhil0 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@adhil0 adhil0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks!

dashboard/src/t5gweb/utils.py
return headers


def format_date(the_date):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be very helpful going forward

@adhil0 adhil0 merged commit 59f063a into main Jul 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhil0 adhil0 adhil0 approved these changes

Assignees

@adhil0 adhil0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcritch @adhil0