Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv: Toolchain check triggers even with BUILD_IN_DOCKER #18653

Closed
chrysn opened this issue Sep 27, 2022 · 0 comments · Fixed by #18654
Closed

riscv: Toolchain check triggers even with BUILD_IN_DOCKER #18653

chrysn opened this issue Sep 27, 2022 · 0 comments · Fixed by #18654
Assignees

Comments

@chrysn
Copy link
Member

chrysn commented Sep 27, 2022

Description

When building on a system that has no relevant toolchains installed, a test is run outside the container even on docker builds, printing:

No RISC-V toolchain detected. Make sure a RISC-V toolchain is installed.

Steps to reproduce the issue

Install a bare system (without any riscv*-gcc installed). Run:

$ make -C examples/hello-world  BUILD_IN_DOCKER=1 BOARD=hifive1b
make: Entering directory '/tmp/RIOT/examples/hello-world'
/tmp/RIOT/makefiles/arch/riscv.inc.mk:37: *** No RISC-V toolchain detected. Make sure a RISC-V toolchain is installed..  Stop.
make: Leaving directory '/tmp/RIOT/examples/hello-world'

Expected results

The test should be performed inside the actual build environment, not outside.

[edit: Assigning to whomever git blame reported, as I'm currently tracking down different urgent issues to get CI running again]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants