makefiles/arch/riscv.inc.mk: Fix with BUILD_IN_DOCKER #18654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With RISC-V being a relatively young toolchain, a lot of inconsistencies between different toolchains are to be found that differ in the target triple and the flags supported. This build system performs run-time tests to detect the toolchain and supported flags. With `BUILD_IN_DOCKER=1` issues arise, as this checks are performed outside of the docker container. However, the host may have no RISC-V toolchain installed or a different toolchain, so there is little reason in performing this detection then. Instead, a hard coded target triple and supported flags are provided when using `BUILD_IN_DOCKER=1`.
maribu
added
Type: bug
benpicco
added
the
CI: ready for build
maribu
added
the
CI: skip compile test
|
thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
With RISC-V being a relatively young toolchain, a lot of inconsistencies between different toolchains are to be found that differ in the target triple and the flags supported. This build system performs run-time tests to detect the toolchain and supported flags.
With
BUILD_IN_DOCKER=1issues arise, as this checks are performed outside of the docker container. However, the host may have no RISC-V toolchain installed or a different toolchain, so there is little reason in performing this detection then. Instead, a hard coded target triple and supported flags are provided when usingBUILD_IN_DOCKER=1.Testing procedure
E.g.
make BOARD=hifive1b BUILD_IN_DOCKER=1 -C examples/defaultshould work even if no host RISC-V toolchain is installed.Issues/PRs references
Fixes #18653