Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: can_fast_ci_run.py misclassifying sub unittests #18987

Closed
kaspar030 opened this issue Nov 28, 2022 · 5 comments · Fixed by #18996
Closed

CI: can_fast_ci_run.py misclassifying sub unittests #18987

kaspar030 opened this issue Nov 28, 2022 · 5 comments · Fixed by #18996
Assignees
@maribu

Comments

@kaspar030
Copy link
Contributor

Description

From #18950

"can_fast_ci_build.py correctly identified just tests/unittests/tests-core as changed, but the build system doesn't understand APPS=tests/unittests/tests-core."

Steps to reproduce the issue

Expected results

Actual results

Versions
@kaspar030
Copy link
Contributor Author

maybe hard-replacing "tests/unittests/*" with "tests/unittests" is a sensible work-around?

@MrKevinWeiss
Copy link
Contributor

Also occurred on #18734

@MrKevinWeiss
Copy link
Contributor

I suppose another workaround would be unittest changes should have the full build label?

@kaspar030
Copy link
Contributor Author

I suppose another workaround would be unittest changes should have the full build label?

yup, but is there a benefit? why not just build all unittests?

kaspar030 added a commit to kaspar030/RIOT that referenced this issue Nov 30, 2022
@kaspar030
ci/can_fast_ci_run.py: add workaround for RIOT-OS#18987

Verified

This commit was signed with the committer’s verified signature. The key has expired.
miri64 Martine Lenders
GPG key ID: 2134D77A5336DD80
Expired
Verified
Learn about vigilant mode
34cfdac
@kaspar030 kaspar030 mentioned this issue Nov 30, 2022
Merged
@MrKevinWeiss
Copy link
Contributor

yup, but is there a benefit? why not just build all unittests?

If there is no fix already in, but you promptly supplied one 👍

Einhornhool pushed a commit to Einhornhool/RIOT that referenced this issue Jan 24, 2023
@kaspar030 @Einhornhool
ci/can_fast_ci_run.py: add workaround for RIOT-OS#18987

Verified

This commit was signed with the committer’s verified signature. The key has expired.
miri64 Martine Lenders
GPG key ID: 2134D77A5336DD80
Expired
Verified
Learn about vigilant mode
426fad2
dylad pushed a commit to dylad/RIOT that referenced this issue Feb 3, 2023
@kaspar030 @dylad
ci/can_fast_ci_run.py: add workaround for RIOT-OS#18987
1dcf3e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maribu maribu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: can_fast_ci_build.py unittests fix kaspar030/RIOT
3 participants
@maribu @kaspar030 @MrKevinWeiss