Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

at86rf2xx: Basic mode and NETOPT_AUTOACK #8213

Closed
roberthartung opened this issue Dec 6, 2017 · 10 comments
Closed

at86rf2xx: Basic mode and NETOPT_AUTOACK #8213

roberthartung opened this issue Dec 6, 2017 · 10 comments
Labels
Area: drivers Area: Device drivers Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@roberthartung
Copy link
Member

  1. Why is it not possible to choose the default RX_MODE (without AACK enabled)?

  2. In at86rf2xx_netdev.c:_set(NETOPT_AUTOACK) the comment says /* don't set res to set netdev_ieee802154_t::flags */. However netdev_ieee802154_set never handles this cases which causes ifconfig <n> set -autoack to fail with an error message. What was the idea behind it?

@roberthartung
Copy link
Member Author

@haukepetersen @miri64 You should be able to answer these questions ;)

@miri64
Copy link
Member

miri64 commented Dec 6, 2017

@haukepetersen @miri64 You should be able to answer these questions ;)

I don't know much about this device driver, except how it interacts with the netdev API ;-), but I can try to answer it with my limited knowledge:

  1. Why is it not possible to choose the default RX_MODE (without AACK enabled)?

I could name you some villages in Bohemia, if you like ;-).

  1. In at86rf2xx_netdev.c:_set(NETOPT_AUTOACK) the comment says /* don't set res to set netdev_ieee802154_t::flags */. However netdev_ieee802154_set never handles this cases which causes ifconfig set -autoack to fail with an error message. What was the idea behind it?

Why would netdev_ieee802154_set handle that case? As far as I know auto-ack is pretty device specific, so this should be done in at86rf2xx_netdev.c:_set().

@roberthartung
Copy link
Member Author

@PeterKietzmann PeterKietzmann added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers labels Dec 13, 2017
@PeterKietzmann
Copy link
Member

@roberthartung #8213 was merged shortly after you opened this issue. Could you give a quick summary of the remaining problem in the current state? If I see it correctly, point 1. was not addressed but I don't quite understand the problem there.

@roberthartung
Copy link
Member Author

@PeterKietzmann You mean #8216? ;-) 2. should be solved from my initial question, but 1. is still not possible, we are still always working in basic operation mode.

@PeterKietzmann
Copy link
Member

we are still always working in basic operation mode.

This confuses me a bit. I was assuming we only provide the extended mode in RIOT?

@roberthartung
Copy link
Member Author

You're absolutely right ... basic mode is not implemented. AACK is extended.

Btw. @PeterKietzmann do you mind if we implement the alternative frame buffer access mode? RIOT is currently writing the buffer first and then starting transmission which is slow. There is also a mode where you can write while preparing the send which is faster.

@PeterKietzmann
Copy link
Member

Why would I mind :-)? It's just that I fear synchronization issues (e.g., sending 6LoWPAN fragments subsequently) and thus, I'd consider this a high impact feature which needs to be tested properly. Going through the release tests would be a good way to go. The cutoff date for high impact features is 26th March.

@PeterKietzmann
Copy link
Member

This relates to ongoing work by @jia200x which is partly described in #11473 and #11483.

@PeterKietzmann
Copy link
Member

PeterKietzmann commented Apr 9, 2020

@roberthartung #13798 got merged. an we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

No branches or pull requests

3 participants