Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/periph_timer: add hifive1 exception #11047

Merged
merged 1 commit into from
Feb 21, 2019
Merged

tests/periph_timer: add hifive1 exception #11047

merged 1 commit into from
Feb 21, 2019

Conversation

kaspar030
Copy link
Contributor

Contribution description

hifive1 (fe310) only supports 32768 as timer frequency.
This PR adds this exception.

Testing procedure

Run on hifive1 with/without fix.

Issues/PRs references

Found via #11041.

@kaspar030 kaspar030 requested a review from smlng February 21, 2019 10:43
@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms labels Feb 21, 2019
@kaspar030
Copy link
Contributor Author

@kenrabold another one.

smlng
smlng approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, looks good and matches xtimer config (which works).

@smlng smlng merged commit 92b3558 into RIOT-OS:master Feb 21, 2019
@kaspar030 kaspar030 deleted the fix_tests_periph_timer_for_hifive1 branch February 21, 2019 13:19
@danpetry danpetry added this to the Release 2019.04 milestone Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlng smlng smlng approved these changes

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2019.04
Development

Successfully merging this pull request may close these issues.
3 participants
@kaspar030 @smlng @danpetry