Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/tunslip: correct typos and refine readme #11363

Merged
merged 1 commit into from
Apr 10, 2019
Merged

tools/tunslip: correct typos and refine readme #11363

merged 1 commit into from
Apr 10, 2019

Conversation

smlng
Copy link
Member

@smlng smlng commented Apr 9, 2019

Contribution description

First, I just found a typo, i.e. interace <-> interface. But then I added some more refinements, but nothing big.

Testing procedure

Nothing to test here, just look at the text and ACK if you agree with my suggested changes.

Issues/PRs references

@smlng smlng added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: tools Area: Supplementary tools labels Apr 9, 2019
@smlng smlng requested a review from miri64 April 9, 2019 15:34
miri64
miri64 approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Simple documentation fix. Would have been nice however to split up the beautification and spelling fixes into two separate commits

@miri64
Copy link
Member

miri64 commented Apr 9, 2019

BTW, might I convince you to have a look at #10477 ;-)?

@smlng
Copy link
Member Author

smlng commented Apr 9, 2019

BTW, might I convince you to have a look at #10477 ;-)?

yep, will do - need (or at least want) to use SLIP for a project

@miri64
Copy link
Member

miri64 commented Apr 9, 2019

yep, will do - need (or at least want) to use SLIP for a project

Then you will love #10477 in combination with #10480 ;-)

@smlng smlng merged commit 53af7eb into RIOT-OS:master Apr 10, 2019
@smlng smlng deleted the pr/tunslip/doc branch April 10, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: doc Area: Documentation Area: network Area: Networking Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smlng @miri64