tests/xtimer_periodic_wakeup: allow for negative difference #11382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some boards (e.g., Hifive1 with 32kHz xtimer), this test shows negative offsets. As the test doesn't do any judgement on the values anyways, change the pexpect script to allow for that.
kaspar030
added
Type: enhancement
|
ping |
|
@kaspar030 based on the discussion in #11493, this one should be closed or adapted to fail on negative offsets right? |
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Some boards (e.g., Hifive1 with 32kHz xtimer), this test shows negative
offsets. As the test doesn't do any judgement on the values anyways,
change the pexpect script to allow for that.
Testing procedure
Ensure that tests still run as expected.
Issues/PRs references
#11041